Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 685 invoked from network); 15 Aug 2006 11:32:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 15 Aug 2006 11:32:32 -0000 Received: (qmail 84981 invoked by uid 500); 15 Aug 2006 11:32:31 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 84628 invoked by uid 500); 15 Aug 2006 11:32:30 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 84617 invoked by uid 99); 15 Aug 2006 11:32:30 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2006 04:32:30 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of david@jetnet.co.uk designates 80.87.128.128 as permitted sender) Received: from [80.87.128.128] (HELO kosh.jetnet.co.uk) (80.87.128.128) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2006 04:32:28 -0700 Received: from localhost (localhost [127.0.0.1]) by kosh.jetnet.co.uk (Postfix) with ESMTP id DB1D0254ED; Tue, 15 Aug 2006 11:32:06 +0000 (GMT) Received: from kosh.jetnet.co.uk ([127.0.0.1]) by localhost (mail.jetnet.co.uk [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 68252-06-3; Tue, 15 Aug 2006 11:32:05 +0000 (GMT) Received: from [192.168.0.124] (82-69-108-39.dsl.in-addr.zen.co.uk [82.69.108.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by kosh.jetnet.co.uk (Postfix) with ESMTP id 6BC99254E9; Tue, 15 Aug 2006 11:32:05 +0000 (GMT) Message-ID: <44E1B0B4.6040005@jetnet.co.uk> Date: Tue, 15 Aug 2006 12:32:04 +0100 From: david reid User-Agent: Thunderbird 1.5.0.5 (X11/20060728) MIME-Version: 1.0 To: Garrett Rooney CC: dev@apr.apache.org Subject: Re: regex References: <44DE3675.5080501@jetnet.co.uk> <7edfeeef0608140701x23c6a9f6ue0c1ff4ab1f1793a@mail.gmail.com> <44E09B56.6070906@jetnet.co.uk> <7edfeeef0608141004r219e7812g8e6ea620e0f1d260@mail.gmail.com> In-Reply-To: <7edfeeef0608141004r219e7812g8e6ea620e0f1d260@mail.gmail.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at jetnet.co.uk X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Garrett Rooney wrote: > On 8/14/06, david reid wrote: >> Garrett Rooney wrote: >> > On 8/12/06, david reid wrote: >> >> After a discussion on irc, I've started lookign at adding pcre support >> >> to apr-util. The patch to start this off is below... >> >> >> >> Not perfect and not quite complete, but I said I'd post early on this >> >> and let others look. >> > >> > What's the advantage to using this instead of just using PCRE directly? >> >> I've heard this a couple of times now, so while I had thought the >> benefits spoke for themselves maybe they don't. > > Well, I'd just like to clarify what the goal is here. Is it just to > provide an API that's nicer to use in a pool based app? Is it to > actually provide a portability layer that uses multiple back end regex > libraries (seems unlikely). I don't necessarily object if all you're > trying to do is make things work better with other apr type code, I > just want to clarify that it is in fact the goal. AFAIK libpcre is the main library that people use for regex support, so I wasn't planning on providing support for anything else. That said, the interface I proposed does abstract out all the libpcre stuff and so other implementation could easily be adopted - I just didn't worry about finding any others. httpd uses pcre via a wrapper already, so moving it into apr-util makes a degree of sense right there. Windows doesn't have builtin regex support, so providing regex via apr-util allows people to write more portable code. A good thing. There are places within apr-util where using regex would be useful. Knowing that I can simply write code that uses regex functionality, confident in the knowledge that lovely, useful apr-util provides it is another good thing. Reducing the dependencies for httpd is a good thing. Providing an interface that provides more of the libpcre extended functionality seems like a good thing. Allowing those using apr-util to benefit from having builtin regex support is a good thing. Asking them to include yet another library is a bad thing. Asking people to learn the intracies of libpcre (not as simple as they seem as I discovered) to simply use a regex pattern in their code is a bad thing. Adding libpcre as a required dependency of apr-util without providing some way of including the library within apr-util's build (for pcre challenged systems) is a nasty thing - and one that I'm surprised people would be happy with. Most of the above seemed to be self evident, so the high level of resistance I saw to my proposal surprised me. The fact that people were happy to complain on IRC but not post to the list worried me. Why did I withdraw my patch from discussion? The level of resistance I saw was quite high and given how many things I'm working on and the fact that the regex support isn't high on any list of things to be done, I decided to cut it from my todo list - freeing my time up for other things. I'd rather be doing productive things than debating pro's and cons of something that people don't want. -- david http://feathercast.org/