From dev-return-17155-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Sep 01 03:18:54 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 3486 invoked from network); 1 Sep 2006 03:18:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Sep 2006 03:18:53 -0000 Received: (qmail 29179 invoked by uid 500); 1 Sep 2006 03:18:51 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 29107 invoked by uid 500); 1 Sep 2006 03:18:51 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 29088 invoked by uid 99); 1 Sep 2006 03:18:51 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2006 20:18:51 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of justin.erenkrantz@gmail.com designates 66.249.92.174 as permitted sender) Received: from [66.249.92.174] (HELO ug-out-1314.google.com) (66.249.92.174) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2006 20:18:50 -0700 Received: by ug-out-1314.google.com with SMTP id m2so838624uge for ; Thu, 31 Aug 2006 20:18:29 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=khCY+eifoDgboxbnq/U3hEBkvfc4DxbncuUPtAKHFVtGAO+eMSTSu4fO5ddTQ7bfC1lInjtangg/J6tfIEmxV1L4j0ovfRxUhFnIl0HYYBUmDyY06lgu/y3ha59zGAv7IHUQF5dvmb9rYa7MffIOTUjBgiK/qO2EUBatfLCV3Gg= Received: by 10.67.100.12 with SMTP id c12mr929397ugm; Thu, 31 Aug 2006 20:18:28 -0700 (PDT) Received: by 10.66.248.3 with HTTP; Thu, 31 Aug 2006 20:18:28 -0700 (PDT) Message-ID: <5c902b9e0608312018m6e968b01la7511e20528d4c60@mail.gmail.com> Date: Thu, 31 Aug 2006 20:18:28 -0700 From: "Justin Erenkrantz" Sender: justin.erenkrantz@gmail.com To: dev@apr.apache.org Subject: Re: svn commit: r438796 - /apr/apr/trunk/atomic/unix/apr_atomic.c Cc: commits@apr.apache.org In-Reply-To: <44F6892D.4030906@rowe-clan.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20060831051022.BBC331A981A@eris.apache.org> <44F6892D.4030906@rowe-clan.net> X-Google-Sender-Auth: 101ac531b1ce534c X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 8/31/06, William A. Rowe, Jr. wrote: > jerenkrantz@apache.org wrote: > > --- apr/apr/trunk/atomic/unix/apr_atomic.c (original) > > +++ apr/apr/trunk/atomic/unix/apr_atomic.c Wed Aug 30 22:10:22 2006 > > @@ -179,7 +179,7 @@ > > #endif /* APR_OVERRIDE_ATOMIC_CAS32 */ > > > > #if !defined(APR_OVERRIDE_ATOMIC_DEC32) > > -APR_DECLARE(apr_uint32_t) apr_atomic_dec32(volatile apr_uint32_t *mem) > > +APR_DECLARE(int) apr_atomic_dec32(volatile apr_uint32_t *mem) > > { > > This appears to be a binary break. > > You realize we can play macro magic to enforce the correct type? > > In any case, unless I'm imagining things, please revert No. apr_atomic.h says: APR_DECLARE(int) apr_atomic_dec32(...) with this Solaris 10 specific Atomics impl saying: APR_DECLARE(apr_uint32_t) apr_atomic_dec32(...) All other implementations of dec32() in apr_atomic.c match the int return - not the uint32_t return. Therefore, on a 64-bit platform, it never could compile with the signature mismatch. My commit allows APR to compile on 64-bit Solaris. -- justin