apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: [PATCH] WIN32 allow destructors for apr_threadkey_private
Date Mon, 21 Aug 2006 15:35:25 GMT
On 8/21/06, Mladen Turk <mturk@apache.org> wrote:
> Garrett Rooney wrote:
> > On 8/21/06, Mladen Turk <mturk@apache.org> wrote:
> >> Garrett Rooney wrote:
> >> > On 8/21/06, Mladen Turk <mturk@apache.org> wrote:
> >> >
> >> > One comment, where did the number 1088 come from?  Should probably
> >> > replace it with a #define or something in any event.
> >> >
> >>
> >> 1088 comes from the MSDN:
> >>
> =>
> > It's the minimum available?  In practice, is that equal to the maximum
> > available as well?  Either way, it seems like a #define with a comment
> > explaining the source of the value is in order.
> >
>
> We can have a define, but only when the #define gets present
> in MSDN. Since the 1088 is the value defined only in docs the
> #define itself is without any real meaning.
>
> Sure, we can have "#define WHAT_EVER 1088", but it would
> have no relation to the MSDN.

Fine, just stick a comment next to it saying "we set WHAT_EVER to 1088
because that's the largest value currently used for the minimum number
of TLS indices on current versions of Windows" so the next guy doesn't
wonder why 1088 is so special.

-garrett

Mime
View raw message