apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: [PATCH] WIN32 allow destructors for apr_threadkey_private
Date Mon, 21 Aug 2006 15:15:58 GMT
On 8/21/06, Mladen Turk <mturk@apache.org> wrote:
> Hi,
>
> pthreads have option to register destruct callback
> for private thread keys created.
> Here is the patch that allow that for WIN32 but
> only when compiled as dll.
>
> Any comments or objections?
> The consequence is that the DllMain is added, and
> I suppose its not possible to have that functionality
> with static apr lib.
> OTOH it allows to have the same behavior like with
> pthreads actually calling provided callback to
> the apr_threadkey_private_create instead just ignoring
> it.

This seems reasonable to me, at least in concept. I looked at the
problem a while back, and didn't see any way to fix it.  Didn't even
occur to me to add a DllMain.

One comment, where did the number 1088 come from?  Should probably
replace it with a #define or something in any event.

-garrett

Mime
View raw message