apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: [PATCH] WIN32 allow destructors for apr_threadkey_private
Date Wed, 23 Aug 2006 14:44:34 GMT
Garrett Rooney wrote:
> On 8/23/06, Mladen Turk <mturk@apache.org> wrote:
> 
> A few on the actual code:
> 
>> -       if (env) {
>> +        if (env) {
>

Right, its a Tab police.


> 
> If this hash is going to be non-static and shared among modules it
> needs to be properly prefixed.  apr_tls_threadkeys instead of
> tls_apr_threadkeys.
>

It is not shared except between two files inside the APR,
and as such is library local variable.

Regards,
Mladen.

Mime
View raw message