apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r428931 - in /apr/apr-util/trunk: include/apr_memcache.h memcache/apr_memcache.c
Date Mon, 07 Aug 2006 11:19:01 GMT
On Sat, Aug 05, 2006 at 12:34:25AM -0000, Paul Querna wrote:
> Author: pquerna
> Date: Fri Aug  4 17:34:25 2006
> New Revision: 428931
> 
> URL: http://svn.apache.org/viewvc?rev=428931&view=rev
> Log:
> Add memcache multi-get support to apr_memcache.

There are a couple more style issues - lots of "type* foo" and some 
"apr_pollset_remove (...)" which shouldn't have a space.

Here:

> +               key = apr_strtok(conn->buffer, " ", &last); // just the VALUE,
ignore
> +               key = apr_strtok(NULL, " ", &last);
> +               flags = apr_strtok(NULL, " ", &last);
> +
> +               length = apr_strtok(NULL, " ", &last);
> +               len = atoi(length);
...

is all the following code safe against unbounded values of len?  The 
comparison against < 0 is useless for an apr_size_t too.

joe

Mime
View raw message