Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <44C3D9D8.90000@rowe-clan.net>
Date: Sun, 23 Jul 2006 15:19:36 -0500
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Thunderbird 1.5.0.4 (X11/20060614)
MIME-Version: 1.0
To: Lieven Govaerts <lgo@mobsol.be>
CC: dev@apr.apache.org
Subject: Re: [PATCH]: apr_filepath_merge on Windows handes ..\..\..
 incorrectly.
 (is Subversion issue 1869)
References: <20060723102844.15CC52200D4@assei1bl6.telenet-ops.be>
In-Reply-To: <20060723102844.15CC52200D4@assei1bl6.telenet-ops.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Lieven Govaerts wrote:
> --- file_io/win32/filepath.c	(revision 422522)
> +++ file_io/win32/filepath.c	(working copy)
> @@ -673,7 +673,7 @@
>                   */
>              }
>              else if (pathlen == 0 ||
> -                     (pathlen >= 3 && (pathlen == 3
> +                     (pathlen >= 3 && (pathlen % 3 == 0
>                                      || path[pathlen - 4] == ':')
>                                     &&  path[pathlen - 3] == '.' 
>                                     &&  path[pathlen - 2] == '.' 

-1 on this specific solution; you are entrusting that path[]'s triplets are
all ../ patterns which definitely isn't a robust test.

There's something deeper going on here, +1 on your test, I'll get that applied
in the next day if nobody beats me to it, so we better ensure this is properly
fixed before release.

This is a great catch - thank you for your report!

Bill