Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 91436 invoked from network); 17 Jul 2006 17:34:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Jul 2006 17:34:29 -0000 Received: (qmail 25869 invoked by uid 500); 17 Jul 2006 17:34:29 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 25577 invoked by uid 500); 17 Jul 2006 17:34:28 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 25562 invoked by uid 99); 17 Jul 2006 17:34:28 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 10:34:28 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [207.155.252.219] (HELO warrior.cnchost.com) (207.155.252.219) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 10:34:27 -0700 Received: from [192.168.0.21] (c-24-15-193-17.hsd1.il.comcast.net [24.15.193.17]) (as wrowe@rowe-clan.net) by warrior.cnchost.com (ConcentricHost(2.54) Relay) with ESMTP id 0B3B821A7; Mon, 17 Jul 2006 13:31:54 -0400 (EDT) Message-ID: <44BBC95A.3030309@rowe-clan.net> Date: Mon, 17 Jul 2006 12:31:06 -0500 From: "William A. Rowe, Jr." User-Agent: Thunderbird 1.5.0.4 (X11/20060614) MIME-Version: 1.0 To: Paul Querna CC: Justin Erenkrantz , dev@apr.apache.org Subject: Re: svn commit: r422157 - /apr/apr/trunk/file_io/win32/filepath.c References: <20060715071635.BA7191A981A@eris.apache.org> <44B9A221.30206@rowe-clan.net> <44B9A585.4060409@force-elite.com> <44B9A74A.7020906@rowe-clan.net> <44BAC78D.9060107@rowe-clan.net> <5c902b9e0607162359k857fa80mca894599606520a2@mail.gmail.com> <44BB956F.2010506@rowe-clan.net> <5c902b9e0607170824l4539e95amd4cb41340a8e6840@mail.gmail.com> <44BBAF2B.5070802@rowe-clan.net> <44BBB480.7090303@force-elite.com> In-Reply-To: <44BBB480.7090303@force-elite.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Paul Querna wrote: > William A. Rowe, Jr. wrote: >> >>> Again, these are the testnames tests that were failing. >> >> Cite them. > > I did, in the commit message: > "This was causing the test failure on testnames line 219." Thanks Paul, let's fix that. And if we feel we should TRUENAME the results of get_path, then we could attack that too.