Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 69286 invoked from network); 24 Jul 2006 10:18:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 Jul 2006 10:18:42 -0000 Received: (qmail 37179 invoked by uid 500); 24 Jul 2006 10:18:41 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 37147 invoked by uid 500); 24 Jul 2006 10:18:40 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 37136 invoked by uid 99); 24 Jul 2006 10:18:40 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2006 03:18:40 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2006 03:18:40 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6OAIImk001281 for ; Mon, 24 Jul 2006 06:18:18 -0400 Received: from turnip.cambridge.redhat.com (turnip.cambridge.redhat.com [172.16.18.137]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6OAIC2F014150 for ; Mon, 24 Jul 2006 06:18:13 -0400 Received: from turnip.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by turnip.cambridge.redhat.com (8.13.6/8.13.5) with ESMTP id k6OAIBGL028253 for ; Mon, 24 Jul 2006 11:18:11 +0100 Received: (from jorton@localhost) by turnip.cambridge.redhat.com (8.13.6/8.13.6/Submit) id k6OAIBrI028252 for dev@apr.apache.org; Mon, 24 Jul 2006 11:18:11 +0100 X-Authentication-Warning: turnip.cambridge.redhat.com: jorton set sender to jorton@redhat.com using -f Date: Mon, 24 Jul 2006 11:18:11 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: svn commit: r424900 - /apr/apr/trunk/test/testnames.c Message-ID: <20060724101811.GB12925@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <20060724042734.9C9271A981A@eris.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20060724042734.9C9271A981A@eris.apache.org> User-Agent: Mutt/1.4.2.1i X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Mon, Jul 24, 2006 at 04:27:33AM -0000, William Rowe wrote: > Author: wrowe > Date: Sun Jul 23 21:27:27 2006 > New Revision: 424900 > > URL: http://svn.apache.org/viewvc?rev=424900&view=rev > Log: > > Revert my last commit. I've determined that data becomes data, while > data/ remains data/. ../../.. should observe the same behavior, so this > is effectively a bug, even if it has no negative impact. The Unix implementation will always append a trailing slash in this case, it seems. The APR_FILEPATH_TRUENAME documentation appears to suggest it should too; is this a bug? > > Modified: > apr/apr/trunk/test/testnames.c > > Modified: apr/apr/trunk/test/testnames.c > URL: http://svn.apache.org/viewvc/apr/apr/trunk/test/testnames.c?rev=424900&r1=424899&r2=424900&view=diff > ============================================================================== > --- apr/apr/trunk/test/testnames.c (original) > +++ apr/apr/trunk/test/testnames.c Sun Jul 23 21:27:27 2006 > @@ -100,7 +100,7 @@ > "../../..", APR_FILEPATH_TRUENAME, p); > ABTS_PTR_NOTNULL(tc, dstpath); > ABTS_INT_EQUAL(tc, APR_SUCCESS, rv); > - ABTS_STR_EQUAL(tc, "../../../", dstpath); > + ABTS_STR_EQUAL(tc, "../../..", dstpath); > > rv = apr_filepath_merge(&dstpath, "", > "../../../", APR_FILEPATH_TRUENAME, p); >