From dev-return-16887-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Jul 12 08:31:09 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 8723 invoked from network); 12 Jul 2006 08:31:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Jul 2006 08:31:08 -0000 Received: (qmail 16471 invoked by uid 500); 12 Jul 2006 08:31:06 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 16448 invoked by uid 500); 12 Jul 2006 08:31:06 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 16437 invoked by uid 99); 12 Jul 2006 08:31:06 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jul 2006 01:31:06 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jul 2006 01:31:05 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6C8Uhxg002809 for ; Wed, 12 Jul 2006 04:30:43 -0400 Received: from turnip.cambridge.redhat.com (turnip.cambridge.redhat.com [172.16.18.137]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6C8UhhZ014046 for ; Wed, 12 Jul 2006 04:30:43 -0400 Received: from turnip.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by turnip.cambridge.redhat.com (8.13.6/8.13.5) with ESMTP id k6C8UgIN030739 for ; Wed, 12 Jul 2006 09:30:42 +0100 Received: (from jorton@localhost) by turnip.cambridge.redhat.com (8.13.6/8.13.6/Submit) id k6C8UgpH030738 for dev@apr.apache.org; Wed, 12 Jul 2006 09:30:42 +0100 X-Authentication-Warning: turnip.cambridge.redhat.com: jorton set sender to jorton@redhat.com using -f Date: Wed, 12 Jul 2006 09:30:42 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: "z" modifier for APR_SIZE_T_FMT? Message-ID: <20060712083042.GA30163@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <20060710210856.GE11764@yi.org> <7edfeeef0607110920n62337e0el7d8ad7b9353c3295@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7edfeeef0607110920n62337e0el7d8ad7b9353c3295@mail.gmail.com> User-Agent: Mutt/1.4.2.1i X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Tue, Jul 11, 2006 at 12:20:03PM -0400, Garrett Rooney wrote: > On 7/10/06, Tyler MacDonald wrote: > >I recently had a bug reported on my package, that it failed to compile > >under > >s390. I guess this is because I was just using "%u" instead of > >APR_SIZE_T_FMT to print the size, but I can't really be sure because I > >don't > >have access to an s390 to compile myself. :) > > > >This led me to check up on what APR_SIZE_T_FMT is actually defined as. On > >my > >system, it's: > > > >#define APR_SIZE_T_FMT "d" > > > >Is there any reason why the "z" modifier is not included here? It seems > >like > >that is what printf(3) says we want to use for formatting size_t types. > > Off the top of my head I'm not sure, perhaps configure just isn't > smart enough to use that if it's available? I'm also not sure if the > apr *printf code knows about that format code... It doesn't, but there's no reason why it couldn't be added. The APR_{S,}SIZE_T_FMT macros are completely redundant if the z modifier is supported, I don't know why that wasn't done to start with, it has meant a lot of ugly code in a lot of places. joe