apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r422157 - /apr/apr/trunk/file_io/win32/filepath.c
Date Mon, 17 Jul 2006 16:02:08 GMT
William A. Rowe, Jr. wrote:
> Justin Erenkrantz wrote:
>> The problem is that the APR code relies on the MSVC run-time being
>> consistent: as we have demonstrated, it's not.  It can and does report
>> c:\ in several circumstances.  
> Yes, and so what?  This should be harmless... please indicate the bug
> that the VETOED code supposedly corrects?
> (And Mr. Committer, revert your vetoed code already.)

I will try to get to it tonight.

>> Note that all APR was doing was
>> toupper() which doesn't handle Unicode either.
> No need.  Drive LETTERS aren't full unicode, the drive letter is ascii.
>> Again, these are the testnames tests that were failing. 
> Cite them.

I did, in the commit message:
"This was causing the test failure on testnames line 219."

View raw message