Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Tue, 20 Jun 2006 11:39:06 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@apr.apache.org
Subject: Re: svn commit: r415591 - in /apr/apr-util/trunk: build/ssl.m4
 configure.in
Message-ID: <20060620103906.GA19328@redhat.com>
Mail-Followup-To: dev@apr.apache.org
References: <20060620095044.D36541A983A@eris.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20060620095044.D36541A983A@eris.apache.org>
User-Agent: Mutt/1.4.2.1i

Hi David,

On Tue, Jun 20, 2006 at 09:50:44AM -0000, David Reid wrote:
> Author: dreid
> Date: Tue Jun 20 02:50:43 2006
> New Revision: 415591
> 
> URL: http://svn.apache.org/viewvc?rev=415591&view=rev
> Log:
> This is the start of allowing SSL usage within apr-util. This is essentially
> the configure glue from my patch of a while ago. I'm adding it now so that
> any issues can be flagged up before the code starts to land. Presently
> this will detect and set appropriate defines but won't do much more :-)

...
> +    if test "$withval" = "yes"; then
> +      old_cppflags="$CPPFLAGS"
> +      old_ldflags="$LDFLAGS"
> +
> +      openssl_CPPFLAGS="-I$withval/include"

= "-Iyes/include"... looks like this was derived from an older copy of 
dbd.m4? Bojan went through fixing similar stuff there recently.

...
> +  dnl Add the libraries we will need now that we have set apu_have_openssl correctly
> +  if test "$apu_have_openssl" = "1"; then
> +    AC_DEFINE([APU_HAVE_OPENSSL], 1, [Define that we have OpenSSL available])
> +    APR_ADDTO(APRUTIL_EXPORT_LIBS,[-lcrypto -lssl])
> +    APR_ADDTO(APRUTIL_LIBS,[-lcrypto -lssl])

Always use "-lssl -lcrypto" because libssl uses symbols defined in 
libcrypto and not the other way round (breaks with static libs 
otherwise).  Should use pkg-config where available to determine 
CPPFLAGS/LDFLAGS as necessary.  (at least do this in the $withval = yes 
case; it's a little more subtle for the $withval != yes case, see 
httpd's acinclude.m4 for the PKG_CONFIG_PATH munging)

Regards,

joe