Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of bojan@rexursive.com designates
 203.171.74.242 as permitted sender)
Message-ID: <20060608095829.u79vt6zn404ssos0@www.rexursive.com>
Date: Thu, 08 Jun 2006 09:58:29 +1000
From: Bojan Smojver <bojan@rexursive.com>
To: dev@apr.apache.org
Subject: Re: svn commit: r412252 -
	/apr/apr-util/trunk/dbd/apr_dbd_sqlite2.c
References: <20060607020444.6C33C1A983A@eris.apache.org>
	<20060607085603.GB17796@redhat.com>
In-Reply-To: <20060607085603.GB17796@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-1;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
User-Agent: Internet Messaging Program (IMP) H3 (4.1.1)

Quoting Joe Orton <jorton@redhat.com>:

> This is really still a long way from "properly" - both the old and new
> code has undefined behaviour because of the function cast.

The following code, from apr_dbd.c, probably won't have an easy fix =20
like the drivers did:

--------------------------------------------------
#define CLEANUP_CAST (apr_status_t (*)(void*))

[..snip..]

APU_DECLARE(int) apr_dbd_transaction_start(const apr_dbd_driver_t *driver,
                                            apr_pool_t *pool, =20
apr_dbd_t *handle,
                                            apr_dbd_transaction_t **trans)
{
     int ret =3D driver->start_transaction(pool, handle, trans);
     if (*trans) {
         apr_pool_cleanup_register(pool, *trans,
                                   CLEANUP_CAST driver->end_transaction,
                                   apr_pool_cleanup_null);
     }
     return ret;
}
APU_DECLARE(int) apr_dbd_transaction_end(const apr_dbd_driver_t *driver,
                                          apr_pool_t *pool,
                                          apr_dbd_transaction_t *trans)
{
     apr_pool_cleanup_kill(pool, trans, CLEANUP_CAST driver->end_transaction=
);
     return driver->end_transaction(trans);
}
--------------------------------------------------

We are just lucky here that driver->end_transaction() takes a txn =20
pointer and returns an int, which is equivalent for most intents and =20
puposes to (apr_status_t (*)(void*)).

--=20
Bojan