Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 80541 invoked from network); 5 Jun 2006 09:52:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Jun 2006 09:52:54 -0000 Received: (qmail 69247 invoked by uid 500); 5 Jun 2006 09:52:53 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 69207 invoked by uid 500); 5 Jun 2006 09:52:52 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 69196 invoked by uid 99); 5 Jun 2006 09:52:52 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2006 02:52:52 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [81.56.215.125] (HELO mail.bulix.org) (81.56.215.125) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2006 02:52:50 -0700 Received: from skikda.appart.bulix.org ([10.0.0.10]) by frog with smtp (Exim 4.62) (envelope-from ) id 1FnBl5-0005Im-91 for dev@apr.apache.org; Mon, 05 Jun 2006 11:52:28 +0200 Received: by skikda.appart.bulix.org (sSMTP sendmail emulation); Mon, 5 Jun 2006 11:52:26 +0200 Date: Mon, 5 Jun 2006 11:52:26 +0200 From: Maxime Petazzoni To: dev@apr.apache.org Subject: Re: svn commit: r411637 - /apr/apr/trunk/network_io/unix/sendrecv.c Message-ID: <20060605095225.GA26682@bulix.org> References: <20060605015216.D3E1B1A983A@eris.apache.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <20060605015216.D3E1B1A983A@eris.apache.org> User-Agent: Mutt/1.5.11+cvs20060403 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, > - int rv, i; > + int rv; > +#if defined(__FreeBSD_version) && __FreeBSD_version < 460001 > + int i; > +#endif I don't want to mess up with APR development too much, but why don't you declare i in the else if block just a few lines after ? i is obviously only used there, and this block is already in a similar pre-compilator conditional block. Would improve code readability I guess. My 2 =A2, - Sam --=20 Maxime Petazzoni (http://www.bulix.org) -- gone crazy, back soon. leave message. --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFEg/7Z7KsOe4Pmrg0RAuDLAJ41guPGQNdcw8dYESUA7pTuZVdZ9wCfar67 FtWcD8+q2140V6UFtFohWCY= =WsUk -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--