From dev-return-16579-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Mon Jun 12 13:27:24 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 32701 invoked from network); 12 Jun 2006 13:27:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Jun 2006 13:27:24 -0000 Received: (qmail 7105 invoked by uid 500); 12 Jun 2006 13:27:23 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 6869 invoked by uid 500); 12 Jun 2006 13:27:22 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 6858 invoked by uid 99); 12 Jun 2006 13:27:22 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jun 2006 06:27:22 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [206.47.199.141] (HELO simmts12-srv.bellnexxia.net) (206.47.199.141) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jun 2006 06:27:20 -0700 Received: from [192.168.0.103] ([65.94.57.175]) by simmts12-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060612132658.VKYL29039.simmts12-srv.bellnexxia.net@[192.168.0.103]>; Mon, 12 Jun 2006 09:26:58 -0400 Message-ID: <448D6BE2.6040904@pearsoncmg.com> Date: Mon, 12 Jun 2006 09:28:02 -0400 From: Chris Darroch Organization: Pearson CTG/CMG User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060423 X-Accept-Language: en-ca, en-us MIME-Version: 1.0 To: Nick Kew CC: dev@apr.apache.org Subject: Re: [PATCH] apr_dbd_oracle.c query/select fixes #37664 References: <448A2A32.6010200@pearsoncmg.com> <200606100958.06179.nick@webthing.com> In-Reply-To: <200606100958.06179.nick@webthing.com> X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Nick Kew wrote: >> The OCIStmtRelease() function should only be used if Oracle statement >> handles have been prepared with OCIStmtPrepare2(), which is only available >> in Oracle 9.2 and above. For now, stick with just OCIHandleFree() and put >> the stuff related to OCIStmtRelease() into unused #ifdef blocks in the >> freeStatement() and freeStatements() APR memory pool callback cleanup >> functions. Note that when OCIStmtRelease() is used in the future, >> OCIHandleFree() should not be used because OCIStmtRelease() will do that >> for you. > > OK. > > Out of interest, where did you find that information? See the "Rules for Statement Caching" in the OCI 9.2 docs; e.g.: http://www.ifi.uio.no/doc/oracle/ora9i/appdev.920/a96584/oci09adv.htm#464310 Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B