apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@gbiv.com>
Subject Re: svn commit: r411890 - /apr/apr-util/trunk/include/apr_ldap_init.h
Date Mon, 05 Jun 2006 19:27:06 GMT
On Jun 5, 2006, at 11:54 AM, bnicholes@apache.org wrote:

> ====================================================================== 
> ========
> --- apr/apr-util/trunk/include/apr_ldap_init.h (original)
> +++ apr/apr-util/trunk/include/apr_ldap_init.h Mon Jun  5 11:54:37  
> 2006
> @@ -35,6 +35,27 @@
>  extern "C" {
>  #endif /* __cplusplus */
>
> +
> +/**
> + * Macro to detect security related return values.
> + */
> +#if defined(LDAP_INSUFFICIENT_ACCESS)
> +#define APU_LDAP_INSUFFICIENT_ACCESS LDAP_INSUFFICIENT_ACCESS
> +#elif defined(LDAP_INSUFFICIENT_RIGHTS)
> +#define APU_LDAP_INSUFFICIENT_ACCESS LDAP_INSUFFICIENT_RIGHTS
> +#endif

Shouldn't that end with

   #else
   #define APU_LDAP_INSUFFICIENT_ACCESS (some reasonable default)
   #endif

It seems odd just to leave it undefined.

....Roy


Mime
View raw message