apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Curt Arnold <carn...@apache.org>
Subject Re: DO NOT REPLY [Bug 39859] New: - apr_socket_create calls unsupp'd SetHandleInformation on WinCE
Date Sat, 24 Jun 2006 03:26:08 GMT
Sorry, I didn't connect the message topic with my recent WinCE  
commits and wasn't paying attention to this thread.

It would have been a lot easier for me to do one bug mondo WinCE  
patch.  However, when I had taken that approach with Borland C++  
related patches on bug 33490, one of the comments from William Rowe  
(http://issues.apache.org/bugzilla/show_bug.cgi?id=33490#c11) was  
that it would be helpful if I would could break keep each patches to  
single purpose so they could be reviewed in isolation.

I guess I could have submitted 15 or patches to one bug report, but  
there would not be a clear indication of when each of the patches  
were committed, rejected or modified.  I've got a revision to one of  
the patches to commit, but I don't have any new WinCE patches in the  
pipeline at the moment.

I've run a smattering of the unit tests on WinCE.  The most annoying  
problem are null pointer exceptions after failures, for example, when  
apr_file_close is called on a file handle when apr_file_open returns  
a failure code.  That unfortunately rudely stops the test suite and  
prevents seeing the overall status.

testdup: crashes on apr_file_close after getting an APR_ENOTIMPL from  
testdir: Opening an empty directory will immediately fail on WinCE  
since there are entries for ".." and ".".  Other versions of Windows  
will successfully open the directory and then return no entries.   
Test do not check that apr_dir_open succeeded and will crashes on  
subsequent call.

I'm not going to try to work through the APR test suite at this time  
other than is necessary for me to pass log4cxx's test suite.

View raw message