apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: DO NOT REPLY [Bug 39859] New: - apr_socket_create calls unsupp'd SetHandleInformation on WinCE
Date Sat, 24 Jun 2006 18:36:12 GMT
Curt Arnold wrote:
> It would have been a lot easier for me to do one bug mondo WinCE patch.  
> However, when I had taken that approach with Borland C++ related patches 
> on bug 33490, one of the comments from William Rowe 
> (http://issues.apache.org/bugzilla/show_bug.cgi?id=33490#c11) was that 
> it would be helpful if I would could break keep each patches to single 
> purpose so they could be reviewed in isolation.

Yes; that's always true Curt.  The concept (in all Apache and most OSS projects)
is to have one patch that does one thing, etc etc.   It makes it possible for
three different committers to come along and each validate one fix.

That one fix wouldn't be 'make apr compile for SkyOS', but might look like 'make
apr_sockets api deal with SkyOS missing transmitfile'.

We were only debating if these were better off as N patches all attached to one
bug, or N bugs with one patch apiece.

My vote would have been for one bug, but really, either way is -fine- :)


View raw message