apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: svn commit: r411890 - /apr/apr-util/trunk/include/apr_ldap_init.h
Date Mon, 05 Jun 2006 20:17:32 GMT
>>> On 6/5/2006 at 1:27 PM, in message
<603AEF1D-D52A-4FC2-ACDD-2E3B01C98CC6@gbiv.com>, "Roy T. Fielding"
<fielding@gbiv.com> wrote:
> On Jun 5, 2006, at 11:54 AM, bnicholes@apache.org wrote:
> 
>>
====================================================================== 
>> ========
>> --- apr/apr-util/trunk/include/apr_ldap_init.h (original)
>> +++ apr/apr-util/trunk/include/apr_ldap_init.h Mon Jun  5 11:54:37 

>> 2006
>> @@ -35,6 +35,27 @@
>>  extern "C" {
>>  #endif /* __cplusplus */
>>
>> +
>> +/**
>> + * Macro to detect security related return values.
>> + */
>> +#if defined(LDAP_INSUFFICIENT_ACCESS)
>> +#define APU_LDAP_INSUFFICIENT_ACCESS LDAP_INSUFFICIENT_ACCESS
>> +#elif defined(LDAP_INSUFFICIENT_RIGHTS)
>> +#define APU_LDAP_INSUFFICIENT_ACCESS LDAP_INSUFFICIENT_RIGHTS
>> +#endif
> 
> Shouldn't that end with
> 
>    #else
>    #define APU_LDAP_INSUFFICIENT_ACCESS (some reasonable default)
>    #endif
> 
> It seems odd just to leave it undefined.
> 
> ....Ro

Yeah, but I'm not sure what a reasonable default is given that the
actual values are coming from various LDAP SDKs.  From what I have been
able to find so far, these are the only two possible values given the
LDAP SDKs that we support.

Brad

Mime
View raw message