Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates
 64.233.184.226 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=lmzFsm71/lhWi9abI4Jxzf7MEe26xa+56MpBiTw4RMb6XcFqqHz1xHYCx9YHeTPEKnV7xDZ57pvFylgjmJOx93NrjH2gdKJQUIFfOO1UVLB4Wm1ZwgRpu5TxMlns+8LOEC/JAkWeV2AtvWXItaLSl+JyPY58RilN4EsI/dmVHHM=
Message-ID: <7edfeeef0605181027j124db524n4e3879f76ae2ff18@mail.gmail.com>
Date: Thu, 18 May 2006 10:27:58 -0700
From: "Garrett Rooney" <rooneg@electricjellyfish.net>
Sender: rooneg@gmail.com
To: "Dave Seidel" <dave@mindreef.com>
Subject: Re: APR_BRIGADE_FOREACH gone?
Cc: apache-modules@covalent.net, dev@apr.apache.org
In-Reply-To: <00c001c67a88$ebbe8370$c02aa8c0@ENOCH>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <00c001c67a88$ebbe8370$c02aa8c0@ENOCH>

On 5/18/06, Dave Seidel <dave@mindreef.com> wrote:
>
>
> Hi all,
>
> I am in the process of porting a module from 2.0.54 to 2.2.2, and I see t=
hat
> the APR_BRIGADE_FOREACH macro, which used to be defined in apr_buckets.c =
is
> no longer there.  What should I be using instead?  I'm also curious to kn=
ow
> why it was removed.  Thanks in advance.

It was deprecated in r58680 and removed in r58952.

Quoting from the log message of the commit that deprecated it:

  Let's get rid of these damned things once and for all... for every line
  of code they save, they seem to introduce two to three bugs.  :)

If you look at the pre-removal apr_buckets.h you'll see some big
comments with warnings about how error prone it is to use.

-garrett