From dev-return-16437-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue May 23 15:51:53 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 50541 invoked from network); 23 May 2006 15:51:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 May 2006 15:51:53 -0000 Received: (qmail 74259 invoked by uid 500); 23 May 2006 15:51:52 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 74108 invoked by uid 500); 23 May 2006 15:51:51 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 74097 invoked by uid 99); 23 May 2006 15:51:51 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2006 08:51:51 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of oscaremma@gmail.com designates 64.233.184.239 as permitted sender) Received: from [64.233.184.239] (HELO wr-out-0506.google.com) (64.233.184.239) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2006 08:51:50 -0700 Received: by wr-out-0506.google.com with SMTP id i23so1360580wra for ; Tue, 23 May 2006 08:51:28 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=p9ifkzvvansXgIlJIcD3Y7F1n6d9FQwIyncaLAgIg6cM8IDhobJU6RG3lf9h9uc8zNkJ74/Ri1KjIO7856kv+mTMk6hQR2UvbJBU7HAc0xy0m2aokroPNL84XF0Rvs3xoP60iAwt66x0ffPCM0K7XvoToRPr3bfr4WVSvbGMkQg= Received: by 10.65.222.17 with SMTP id z17mr2024242qbq; Tue, 23 May 2006 08:51:28 -0700 (PDT) Received: by 10.65.244.4 with HTTP; Tue, 23 May 2006 08:51:28 -0700 (PDT) Message-ID: <3ce0569d0605230851v2ae896fcm1de108978da48125@mail.gmail.com> Date: Tue, 23 May 2006 11:51:28 -0400 From: "David Jones" To: "David Jones" , dev@apr.apache.org Subject: Re: [PATCH] Apache httpd's htdbm support program delete function fails on 64bit platform In-Reply-To: <20060522081035.GA32200@redhat.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_58819_7540380.1148399488488" References: <3ce0569d0605191211h33624c6dsf1eadee307af3a1e@mail.gmail.com> <20060522081035.GA32200@redhat.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_58819_7540380.1148399488488 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Yes, thanks. I will remove my fix and apply this one instead and retest. If it doesn't solve it I'll reappend. On 5/22/06, Joe Orton wrote: > > On Fri, May 19, 2006 at 03:11:57PM -0400, David Jones wrote: > > Apache httpd's htdbm support program SDBM delete on 64bit fails with > 'Cannot > > find user'. (create,add,list still work) > > What version of httpd and apr-util? The specific bug you describe was > fixed by http://svn.apache.org/viewvc?view=3Drev&revision=3D58990 unless > there was something missed there? > > > This is an endian issue as well since htdbm -x works on a 64bit AMD > machine, > > but not sparc or z/OS. > > > > dsize.apr_sdbm_datum_t in apr_sdbm.h has int dcl, but should be using > > apr_size_t to insure the field is not being truncated > > in the apr_dbm_exists->vt_sdbm_exists->apr_sdbm_fetch flow. > > The CONVERT_DATUM macro is supposed to handle this correctly. > > joe > ------=_Part_58819_7540380.1148399488488 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Yes, thanks. I will remove my fix and apply this one instead and retes= t. If it doesn't solve it I'll reappend. 

On 5/22/06, = Joe Orton <jorton@redhat.com> wrote:
On Fri, May 19, 2006 at 03:11:57= PM -0400, David Jones wrote:
> Apache httpd's htdbm support program S= DBM delete on 64bit fails with 'Cannot
> find user'. (create,add,list still work)

What version of ht= tpd and apr-util?  The specific bug you describe was
fixed by = ht= tp://svn.apache.org/viewvc?view=3Drev&revision=3D58990 unless
there was something missed there?

> This is an end= ian issue as well since htdbm -x works on a 64bit AMD machine,
> but = not sparc or z/OS.
>
> dsize.apr_sdbm_datum_t in apr_sdbm.h has= int dcl, but should be using
> apr_size_t to insure the field is not being truncated
> in t= he apr_dbm_exists->vt_sdbm_exists->apr_sdbm_fetch flow.

The CO= NVERT_DATUM macro is supposed to handle this correctly.

joe

------=_Part_58819_7540380.1148399488488--