apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject [PATCH]: Make MySQL detection a bit more accurate
Date Mon, 22 May 2006 01:06:53 GMT
I tested this on Fedora Core 5 and RHEL4 (both x86_64) and it appeared  
to work fine with packaged version of MySQL 5.0 and 4.1. However,  
environments vary wildly, so it it would be good to get some feedback  
before going ahead with the commit.

I'm a little bit worried that --libs_r may put a bit too much into  
APRUTIL_LDFLAGS (e.g. on FC5 this turns out to be: "-L/usr/lib64/mysql  
-lmysqlclient_r -lz -lpthread -lcrypt -lnsl -lm -lpthread -L/usr/lib64  
-lssl -lcrypto"). Not sure if things like that can hurt the builds...

The logic behind the patch is supposed to be: if there is mysql_config  
we can see, trust it to do the right thing. Otherwise, try using what  
we had before.

There is also a fix for -I$withval/include/mysql where $withval is  
"yes", which was obviously incorrect (i.e. not many people will have  
MySQL header files in "yes/include/mysql" directory :-).

PS. This will not work for MySQL 3.x, as it doesn't have "mysql_config  
--include" call, but "mysql_config --cflags" instead. However, I don't  
think we support MySQL that far back anyway. If that's wrong, we can  
test if mysql_config supports the --include option.

-- 
Bojan

Mime
View raw message