apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH]: Make MySQL detection a bit more accurate
Date Mon, 22 May 2006 10:12:35 GMT
Hi Bojan - some comments on the autoconf code:

> Index: build/dbd.m4
> ===================================================================
> --- build/dbd.m4	(revision 408512)
> +++ build/dbd.m4	(working copy)
> @@ -77,24 +77,40 @@
>    ], [
>      apu_have_mysql=0
>      if test "$withval" = "yes"; then
> +      AC_PATH_PROG([mysqlconfig],[mysql_config])

With AC_PATH_PROG the program name should be in capitals by convention; 
AC_PATH_PROG(MYSQL_CONFIG, ...)

> +      if test "x$$mysqlconfig" != "x"; then
> +        CPPFLAGS="`$mysqlconfig --include`"
> +        LDFLAGS="`$mysqlconfig --libs_r`"

You should never overwrite CPPFLAGS/LDFLAGS like this; use:

   mysql_CPPFLAGS=`...`
   mysql_LDFLAGS=`...`
   APR_ADDTO(CPPFLAGS, [$mysql_CPPFLAGS])
   APR_ADDTO(LDFLAGS, [$mysql_LDFLAGS])

and then just add those variables to the APRUTIL_* variables later if 
the test is successful.  You should really also preserve the original 
CPPFLAGS/LDFLAGS before modifying them and reset them to the old values 
if the test fails.

Regards,

joe

Mime
View raw message