apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Dubov <oa...@yahoo.com>
Subject Re: [PATCH]: improved error reporting for apr_dbd_mysql.c - correct version
Date Mon, 22 May 2006 02:12:28 GMT
Ok. Here is a patch against webthing's rev 34 (I
assume it's a last one). There's a brief changelog in
the beginning of the file.

Two warnings, however:
1. I only use mysql-5
2. I only work with prepared statements
(I don't know if there are any errors in other modes
of operation; I also believe that there can be serious
differences between mysql-5 and mysql-4 in handling of
prepared statements).

Also: my patch does not uses is_null and error arrays
(these are set to zero) - instead is_null_value and
error_value are checked in result's BIND structure.

I also don't have any pre-set bounds on maximum field
length and I don't know what happens if somebody tries
to pass LONG BLOB (the only type which can have
unreasonable size). It's easy to work around long
blobs using SUBSTRING sql statement with offset/size
as parameters, but in general some sort of
truncation/continuation interface is probably needed
(and some interface for mysql_stmt_send_long_data, to
send long data back to db). On the other hand, the
need for such long data in databases is rather limited.

Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
View raw message