apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: [PATCH]: APU DBD documentation cleanup (some)
Date Fri, 05 May 2006 12:47:56 GMT
On Friday 05 May 2006 03:24, Bojan Smojver wrote:
> Before I commit this, I would like to make sure that additional
> explanations are useful and based on real behaviour of DBD. There is
> some simplification in relation to apr_dbd_prepare() syntax, but
> that's on purpose.

Hmmm, some comments.  Don't take this as a thumbs down
(except perhaps the one about the transaction cleanup);
just food for thought.

On apr_dbd_open, your remarks about specific drivers don't really
belong there, IMHO.  The connection string documentation is already
in the manual:
http://httpd.apache.org/docs/2.2/mod/mod_dbd.html#dbdparams

transaction_start: Your remark is correct, but is just documenting
standard APR behaviour.  There's a more important programming
consideration: for a module to rely on this cleanup is wrong,
because it will pollute the connection for any other module that
uses the connection whilst processing the same request.
Your second remark is also correct, but that's likely to change
as we're updating transaction behaviour.

prepare: That's OK, but very specific, and will call for updating
whenever a driver is updated.  Instead of the final sentence,
how about something more generic like "Some drivers may
support different data types using printf-like format: for example
%d or %f for numeric data."


-- 
Nick Kew

Mime
View raw message