apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [PATCH]: Make MySQL detection a bit more accurate
Date Mon, 22 May 2006 21:09:58 GMT
On Mon, 2006-05-22 at 11:12 +0100, Joe Orton wrote:

> With AC_PATH_PROG the program name should be in capitals by convention; 
> AC_PATH_PROG(MYSQL_CONFIG, ...)

OK.

> You should never overwrite CPPFLAGS/LDFLAGS like this; use:
> 
>    mysql_CPPFLAGS=`...`
>    mysql_LDFLAGS=`...`
>    APR_ADDTO(CPPFLAGS, [$mysql_CPPFLAGS])
>    APR_ADDTO(LDFLAGS, [$mysql_LDFLAGS])
> 
> and then just add those variables to the APRUTIL_* variables later if 
> the test is successful.  You should really also preserve the original 
> CPPFLAGS/LDFLAGS before modifying them and reset them to the old values 
> if the test fails.

Aha, I think current dbd.m4 may have problems there already. The current
code overwrites CPPFLAGS/LDFLAGS without restoring the old values.
Probably needs fixing.

Thanks for reviewing.

-- 
Bojan


Mime
View raw message