Return-Path: 
 <dev-return-16175-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: (qmail 99448 invoked from network); 29 Apr 2006 02:00:34 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 29 Apr 2006 02:00:34 -0000
Received: (qmail 20796 invoked by uid 500); 29 Apr 2006 02:00:33 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 20748 invoked by uid 500); 29 Apr 2006 02:00:32 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Id: <dev.apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 20720 invoked by uid 99); 29 Apr 2006 02:00:32 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2006 19:00:32 -0700
X-ASF-Spam-Status: No, hits=1.3 required=10.0
	tests=HTML_MESSAGE,RCVD_IN_BL_SPAMCOP_NET,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of slowhog@gmail.com designates
 66.249.92.173 as permitted sender)
Received: from [66.249.92.173] (HELO uproxy.gmail.com) (66.249.92.173)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2006 19:00:31 -0700
Received: by uproxy.gmail.com with SMTP id m3so1635288ugc
        for <dev@apr.apache.org>; Fri, 28 Apr 2006 19:00:10 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:references:x-google-sender-auth;
        b=X62ATwRIAJdHY5xr8/9f40bvFuFIJ10PBzhsZLaC34x846YLlG9hmQcSKGAq4vfhhOZu8NfJ3na/oPMjSrmbTa+1zhW4fU/sjHK3yPDGHDRLlel1VNwwLq7jRhrZ8zSvUMdXR8dbcYiREWEqRH0sAQe1wE6Y6974j5Nwa19TUNY=
Received: by 10.78.29.13 with SMTP id c13mr482826huc;
        Fri, 28 Apr 2006 19:00:10 -0700 (PDT)
Received: by 10.78.23.3 with HTTP; Fri, 28 Apr 2006 19:00:10 -0700 (PDT)
Message-ID: <369011d00604281900v1ee22604ife70fa45bca6cfda@mail.gmail.com>
Date: Fri, 28 Apr 2006 19:00:10 -0700
From: "Henry Jen" <henryjen@ztune.net>
Sender: slowhog@gmail.com
To: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: Makefile.in does not take external LIBS LDFLAGS
Cc: "APR Development List" <dev@apr.apache.org>
In-Reply-To: <4438C256.9030700@rowe-clan.net>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_Part_413_30711826.1146276010066"
References: <442DB9D9.3030107@ztune.net> <4438C256.9030700@rowe-clan.net>
X-Google-Sender-Auth: d3bca607384f497d
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

------=_Part_413_30711826.1146276010066
Content-Type: multipart/alternative;
	boundary="----=_Part_414_5848385.1146276010066"

------=_Part_414_5848385.1146276010066
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Here is the new patch.

Cheers,
Henry


On 4/9/06, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
>
> Henry Jen wrote:
> >
> > will not have the -R flag in the Makefile.
>
> Your patch is invalid because we need to proxy the whole accumulated
> LDFLAGS off to the client who's trying to compile against apr[-util].
> Fixing Makefile isn't enough, LDFLAGS must be 'sticky' within the
> accumulated apr-1-config/apu-1-config syntax.
>
> Please revisit your patch and determine where your desired flags are
> being dumped by autoconf, and I'd be happy to commit a patch that
> ensures those user-given flags percolate into our APRUTIL_LDFLAGS
> throughout the configuration, as opposed to committing a bandaid.
>
> Yours,
>
> Bill
>

------=_Part_414_5848385.1146276010066
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Here is the new patch.<br><br>Cheers,<br>Henry<br><br><br><div><span class=
=3D"gmail_quote">On 4/9/06, <b class=3D"gmail_sendername">William A. Rowe, =
Jr.</b> &lt;<a href=3D"mailto:wrowe@rowe-clan.net">wrowe@rowe-clan.net</a>&=
gt; wrote:
</span><blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rg=
b(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Henry Jen =
wrote:<br>&gt;<br>&gt; will not have the -R flag in the Makefile.<br><br>Yo=
ur patch is invalid because we need to proxy the whole accumulated
<br>LDFLAGS off to the client who's trying to compile against apr[-util].<b=
r>Fixing Makefile isn't enough, LDFLAGS must be 'sticky' within the<br>accu=
mulated apr-1-config/apu-1-config syntax.<br><br>Please revisit your patch =
and determine where your desired flags are
<br>being dumped by autoconf, and I'd be happy to commit a patch that<br>en=
sures those user-given flags percolate into our APRUTIL_LDFLAGS<br>througho=
ut the configuration, as opposed to committing a bandaid.<br><br>Yours,
<br><br>Bill<br></blockquote></div><br>

------=_Part_414_5848385.1146276010066--

------=_Part_413_30711826.1146276010066
Content-Type: text/x-patch; name=configure.diff; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Attachment-Id: f_emlazlr2
Content-Disposition: attachment; filename="configure.diff"

Index: configure.in
===================================================================
--- configure.in	(revision 398058)
+++ configure.in	(working copy)
@@ -97,6 +97,10 @@
 APR_ADDTO(CFLAGS, `$apr_config --cflags`)
 APR_ADDTO(CPPFLAGS, `$apr_config --cppflags`)
 
+dnl carry user defined LDFLAGS
+APR_ADDTO(APRUTIL_LDFLAGS, "$LDFLAGS")
+APR_ADDTO(APRUTIL_LIBS, "$LIBS")
+
 dnl
 dnl  Find the APR-ICONV directory.
 dnl


------=_Part_413_30711826.1146276010066--