Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of bojan@rexursive.com designates
 203.171.74.242 as permitted sender)
Message-ID: <20060403153049.g9c0ncep6ogssgcc@www.rexursive.com>
Date: Mon, 03 Apr 2006 15:30:49 +1000
From: Bojan Smojver <bojan@rexursive.com>
To: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Cc: dev@apr.apache.org
Subject: Re: svn commit: r390549 - /apr/apr-util/trunk/include/apr_dbd.h
References: <20060401002815.45737.qmail@minotaur.apache.org>
	<442DEBDF.6050601@rowe-clan.net>
	<20060403085929.qbfbaelp7kk008co@www.rexursive.com>
	<7edfeeef0604021814s54a0f868rfcbf0c3c58fa6e3a@mail.gmail.com>
	<20060403115145.u6foxmjra8kgoso0@www.rexursive.com>
	<4430AF27.80306@rowe-clan.net>
In-Reply-To: <4430AF27.80306@rowe-clan.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-1;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.1)

Quoting "William A. Rowe, Jr." <wrowe@rowe-clan.net>:

> Right - I wasn't being critical of your specific new fn, but just a general
> observation.  In the past, we created renames_proposed to collect a list for
> review and comment before committing the changes; if you agree with the
> syntax _get _set etc, then let's start that list again.

apr_dbd_get_driver -> apr_dbd_driver_get
apr_dbd_check_conn -> apr_dbd_conn_check
apr_dbd_set_dbname -> apr_dbd_dbname_set
apr_dbd_get_row    -> apr_dbd_row_get
apr_dbd_get_entry  -> apr_dbd_entry_get
apr_dbd_get_name   -> apr_dbd_name_get

I picked this list up from here (hopefully I didn't miss any):

http://svn.apache.org/viewcvs.cgi/apr/apr-util/trunk/include/apr_dbd.h?rev=390549&view=markup

I don't think we need to touch private functions. Users never see them  
anyway. And it's always good to confuse ourselves - just when you  
think you got the hang of the naming convention, the private functions  
don't follow it ;-)

-- 
Bojan