From dev-return-16170-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Apr 28 13:42:26 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 75241 invoked from network); 28 Apr 2006 13:42:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 28 Apr 2006 13:42:24 -0000 Received: (qmail 15734 invoked by uid 500); 28 Apr 2006 13:42:21 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 15592 invoked by uid 500); 28 Apr 2006 13:42:20 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 15547 invoked by uid 99); 28 Apr 2006 13:42:20 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2006 06:42:20 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [206.47.199.164] (HELO simmts6-srv.bellnexxia.net) (206.47.199.164) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2006 06:42:19 -0700 Received: from [192.168.0.103] ([65.95.243.248]) by simmts6-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060428134156.IKUN25660.simmts6-srv.bellnexxia.net@[192.168.0.103]>; Fri, 28 Apr 2006 09:41:56 -0400 Message-ID: <44521BA5.30302@pearsoncmg.com> Date: Fri, 28 Apr 2006 09:41:57 -0400 From: Chris Darroch Organization: Pearson CTG/CMG User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060423 X-Accept-Language: en-ca, en-us MIME-Version: 1.0 To: Bojan Smojver CC: dev@apr.apache.org Subject: Re: [PATCH]: Introduce apr_dbd_transaction_rollback References: <20060428145749.jh5cf8eqsw8osoc0@www.rexursive.com> <200604281031.08602.nick@webthing.com> <1146219362.6367.3.camel@coyote.rexursive.com> In-Reply-To: <1146219362.6367.3.camel@coyote.rexursive.com> X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Bojan: > On Fri, 2006-04-28 at 10:31 +0100, Nick Kew wrote: > >> What's missing is the option to rollback even when successful. >> In principle, a "rollback" argument to transaction_end would be >> a better way to accomplish this. What level of version bump would >> we need to introduce that? > > Given that this would break binary compatibility, it would have to be > done in 2.x. The "new function approach" could be done for 1.3. This is great either way -- it's been on my to-do list but I've had to keep punting on it. Delighted to see something disappear off the list! As a not-committer, I don't really have a say here, but either option seems fine to me in terms of functionality (obviously). My gut instinct would be that I prefer the "rollback" argument Nick suggests purely for elegance, and that since apr_dbd is relatively new, breaking binary compatibility (so long as it's done with the appropriate version bumps) in the name of a clean interface isn't too horrible. Now I'm partly assuming that there can't be zillions of users yet relying on it in a 1.3 environment who really also need a forceable rollback feature, and that those who do can upgrade to 2.x. (After all, isn't it good to provide these little inducements to encourage folks to upgrade? :-) Whatever is chosen, kudos for dealing with this. Thanks! Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B