Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates
 64.233.182.193 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=MFyE6Ilyvzlb1duAh53Dvkiq3OVB2tgWP31dEwu3oy/zn/7RGo4dMF26ys6YlbdfYO1fHEkZVjllMR2ED77bebHfjfA/HeFnPB/W4qiaIDV0FIrK1bLtrEpw/43lNhCg+YDq6CG+uQC5vps+JV2DPvYhg/e9cI6IChsa6gdb1fc=
Message-ID: <7edfeeef0603151313m492639c8of53a0ce471dd84b6@mail.gmail.com>
Date: Wed, 15 Mar 2006 13:13:58 -0800
From: "Garrett Rooney" <rooneg@electricjellyfish.net>
Sender: rooneg@gmail.com
To: "APR Development List" <dev@apr.apache.org>
Subject: Re: testpoll.c:multi_event_pollset and 1.2.x
In-Reply-To: <7edfeeef0603151036u1c9c359eideacdd4a108e4b5d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <7edfeeef0603141319t7372632ai63eabff105476fa3@mail.gmail.com>
	 <20060315120905.GC17779@redhat.com>
	 <7edfeeef0603151036u1c9c359eideacdd4a108e4b5d@mail.gmail.com>

On 3/15/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 3/15/06, Joe Orton <jorton@redhat.com> wrote:
>
> > Returning two separate descriptors should be valid behaviour, the test
> > just needs to be adjusted to handle that case; it'll still catch the bu=
g
> > in the select() backend.  Can you try this patch?
>
> Tried on FreeBSD:
>
> > Index: testpoll.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- testpoll.c  (revision 385518)
> > +++ testpoll.c  (working copy)
> > @@ -309,10 +309,25 @@
> >
> >      rv =3D apr_pollset_poll(pollset, 0, &lrv, &descs);
> >      ABTS_INT_EQUAL(tc, 0, APR_STATUS_IS_TIMEUP(rv));
> > -    ABTS_INT_EQUAL(tc, 1, lrv);
> > -    ABTS_PTR_EQUAL(tc, s[0], descs[0].desc.s);
> > -    ABTS_INT_EQUAL(tc, APR_POLLIN | APR_POLLOUT, descs[0].rtnevents);
> > -    ABTS_PTR_EQUAL(tc, s[0],  descs[0].client_data);
> > +    if (lrv =3D=3D 1) {
> > +        ABTS_PTR_EQUAL(tc, s[0], descs[0].desc.s);
> > +        ABTS_INT_EQUAL(tc, APR_POLLIN | APR_POLLOUT, descs[0].rtnevent=
s);
> > +        ABTS_PTR_EQUAL(tc, s[0], descs[0].client_data);
> > +    }
> > +    else if (lrv =3D=3D 2) {
> > +        ABTS_PTR_EQUAL(tc, s[0], descs[0].desc.s);
> > +        ABTS_PTR_EQUAL(tc, s[0], descs[0].client_data);
> > +        ABTS_PTR_EQUAL(tc, s[0], descs[1].desc.s);
> > +        ABTS_PTR_EQUAL(tc, s[0], descs[1].client_data);
> > +        ABTS_ASSERT(tc, "returned events incorrect",
> > +                    ((descs[0].rtnevents | descs[1].rtnevents)
> > +                     =3D=3D (APR_POLLIN | APR_POLLOUT))
> > +                    && descs[0].rtnevents !=3D descs[1].rtnevents);
>
> This fails because both rtnevents are actually APR_POLLIN | APR_POLLOUT.
>
> > +    }
> > +    else {
> > +        ABTS_ASSERT(tc, "either one or two events returned",
> > +                    lrv =3D=3D 1 || lrv =3D=3D 2);
> > +    }
> >
> >      recv_msg(s, 0, p, tc);
> >
>
> If we get past that point, we later fail because at the line:
>
> ABTS_INT_EQUAL(tc, APR_POLLOUT, descs[0].rtnevents);
>
> The rtnevents is again APR_POLLIN | APR_POLLOUT.  Not clear why that's
> the case, but there we have it...

Figured it out.  See r386154 for the fix.  Long standing bug in the
kqueue code.  Will backport to 1.2.x real soon now.

-garrett