From dev-return-15669-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Mar 14 21:20:04 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 51778 invoked from network); 14 Mar 2006 21:20:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Mar 2006 21:20:04 -0000 Received: (qmail 90668 invoked by uid 500); 14 Mar 2006 21:19:57 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 90359 invoked by uid 500); 14 Mar 2006 21:19:55 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 90015 invoked by uid 99); 14 Mar 2006 21:19:54 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2006 13:19:54 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates 64.233.182.203 as permitted sender) Received: from [64.233.182.203] (HELO nproxy.gmail.com) (64.233.182.203) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2006 13:19:53 -0800 Received: by nproxy.gmail.com with SMTP id x37so1153025nfc for ; Tue, 14 Mar 2006 13:19:31 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=rPFg2UUxDcSH9bJKKSZpkQLwpV4lgO21qE3LHweE55ZOaDHmYIWzldvwKuXXAjzkFV4U1iyzQaRj/Y1RkuLLmp5xdYy+5w4TV69XZlzJ96XxITuI56fRbDMKA3u0BLX7NaU7u2cGrSzHjy4ZANTRgV0/nVlG/epWwhlfVIPbm1Y= Received: by 10.49.43.1 with SMTP id v1mr1553500nfj; Tue, 14 Mar 2006 13:19:31 -0800 (PST) Received: by 10.49.64.16 with HTTP; Tue, 14 Mar 2006 13:19:31 -0800 (PST) Message-ID: <7edfeeef0603141319t7372632ai63eabff105476fa3@mail.gmail.com> Date: Tue, 14 Mar 2006 13:19:31 -0800 From: "Garrett Rooney" Sender: rooneg@gmail.com To: "APR Development List" Subject: testpoll.c:multi_event_pollset and 1.2.x MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Does anyone have an objection to reverting the addition of the new multi_event_pollset test on the 1.2.x branch? It's testing for behavior that's never existed for a number of pollset back ends (at least kqueue, potentially epoll as well), and nobody has jumped up to make the test pass on those platforms in trunk, let alone get a fix that can be backported. For the curious, the problem is that kqueue doesn't consolidate the events it returns, so you can get two separate events for the same file descriptor, some read, some write, etc. Given that we've always had this behavior in the 1.x releases and nobody's complained about it, I'm willing to just say that the test is bogus. If someone wants to rework the kqueue (and probably epoll) impls to meet this new standard that's something that can be discussed, but for now there's no real justification for us to suddenly condemn their behavior. Thoughts? -garrett