apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Alvarado Hernández" <aalvara...@gmail.com>
Subject Fwd: [PATCH] apr_gid_get on Win32 access violation
Date Mon, 27 Mar 2006 20:22:41 GMT
> ---------- Forwarded message ----------
> From: Garrett Rooney <rooneg@electricjellyfish.net>
> Date: Mar 27, 2006 9:45 PM
> Subject: Re: [PATCH] apr_gid_get on Win32 access violation
> To: Antonio Alvarado Hernández <aalvaradoh@gmail.com>
> Cc: dev@apr.apache.org
>
> On 3/27/06, Antonio Alvarado Hernández <aalvaradoh@gmail.com> wrote:
> > Hello.
> >
> > Following is a nano patch to avoid "Access violation" on testall.exe
> > when call "apr_gid_get" with a NULL groupname on Win32, for your
> > consideration.
>
> APR doesn't generally check for NULL input on function arguments, it's
> the responsibility of the caller to not pass invalid arguments.  This
> problem should be fixed at the level of the calling code.

Oops.... Sorry. I just take this stuff from apr_gid_name_get where put:
    ...
    if (!groupid)
        return APR_EINVAL;
    ...

Regards,
Antonio

Mime
View raw message