apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r388595 - /apr/apr-util/trunk/buildconf
Date Sat, 25 Mar 2006 10:07:40 GMT
wrowe@apache.org wrote:
> Author: wrowe
> Date: Fri Mar 24 10:21:34 2006
> New Revision: 388595
> 
> URL: http://svn.apache.org/viewcvs?rev=388595&view=rev
> Log:
> 
>   Version guard; avoid seeing an installed 1.2.x or earlier apr
>   when configuring apr-util.
> 
> Modified:
>     apr/apr-util/trunk/buildconf
> 
> Modified: apr/apr-util/trunk/buildconf
> URL: http://svn.apache.org/viewcvs/apr/apr-util/trunk/buildconf?rev=388595&r1=388594&r2=388595&view=diff
> ==============================================================================
> --- apr/apr-util/trunk/buildconf (original)
> +++ apr/apr-util/trunk/buildconf Fri Mar 24 10:21:34 2006
> @@ -19,7 +19,15 @@
>  
>  # Default place to look for apr source.  Can be overridden with 
>  #   --with-apr=[directory]
> +
>  apr_src_dir=../apr
> +apr_config=`which apr-1-config`
> +if test $? -eq 0; then
> +    apr_minorver=`$apr_config --version|cut -d. -s -f2`
> +    if test $apr_minorver -ge 3; then
> +        apr_src_dir=`$apr_config --srcdir`
> +    fi
> +fi

-1 on this commit, please revert.

Using 'which' isn't portable:
http://mail-archives.apache.org/mod_mbox/httpd-dev/200502.mbox/%3C20050203153841.GB11454@redhat.com%3E


Mime
View raw message