apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: svn commit: r388595 - /apr/apr-util/trunk/buildconf
Date Sat, 25 Mar 2006 09:19:21 GMT
On Fri, Mar 24, 2006 at 06:21:38PM -0000, wrowe@apache.org wrote:
> Author: wrowe
> Date: Fri Mar 24 10:21:34 2006
> New Revision: 388595
> 
> URL: http://svn.apache.org/viewcvs?rev=388595&view=rev
> Log:
> 
>   Version guard; avoid seeing an installed 1.2.x or earlier apr
>   when configuring apr-util.

Thanks for breaking the build on Solaris.

> Modified:
>     apr/apr-util/trunk/buildconf
> 
> Modified: apr/apr-util/trunk/buildconf
> URL: http://svn.apache.org/viewcvs/apr/apr-util/trunk/buildconf?rev=388595&r1=388594&r2=388595&view=diff
> ==============================================================================
> --- apr/apr-util/trunk/buildconf (original)
> +++ apr/apr-util/trunk/buildconf Fri Mar 24 10:21:34 2006
> @@ -19,7 +19,15 @@
>  
>  # Default place to look for apr source.  Can be overridden with 
>  #   --with-apr=[directory]
> +
>  apr_src_dir=../apr
> +apr_config=`which apr-1-config`
> +if test $? -eq 0; then
> +    apr_minorver=`$apr_config --version|cut -d. -s -f2`
> +    if test $apr_minorver -ge 3; then
> +        apr_src_dir=`$apr_config --srcdir`
> +    fi
> +fi

% ./buildconf
./buildconf: no: not found
./buildconf: test: argument expected

(Solaris 10)

I don't even have a foggy clue what you're trying to do, but this busts
buildconf.  And, it's *never* valid to assume that the srcdir exists for an
installed APR - assume binary packages, etc, etc.

>  
>  while test $# -gt 0 
>  do
> @@ -39,6 +47,7 @@
>  done
>  
>  if [ -f "$apr_src_dir/build/apr_common.m4" ]; then
> +  apr_src_dir=`cd $apr_src_dir; pwd`
>    echo ""
>    echo "Looking for apr source in $apr_src_dir"
>  else

I don't even want to know what this change is, but eww.  -- justin

Mime
View raw message