Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 45127 invoked from network); 4 Feb 2006 12:58:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Feb 2006 12:58:31 -0000 Received: (qmail 30303 invoked by uid 500); 4 Feb 2006 12:58:30 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 30271 invoked by uid 500); 4 Feb 2006 12:58:30 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 30259 invoked by uid 99); 4 Feb 2006 12:58:30 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Feb 2006 04:58:30 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of trawick@gmail.com designates 64.233.162.200 as permitted sender) Received: from [64.233.162.200] (HELO zproxy.gmail.com) (64.233.162.200) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Feb 2006 04:58:28 -0800 Received: by zproxy.gmail.com with SMTP id 8so803876nzo for ; Sat, 04 Feb 2006 04:58:08 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=b1Hwxh9Dhmys8JjIxtQy+KpOj62dMkPab5T0um35wxg8y4shqwUaAoxsMQpIUFITEg+QFZ/g17OrdAe44VCJ1koy4wetiBz6jHuhzcdBXEQATXvlQWkDLSY/yCNfmRhILYBLZwaX6vLObS2I8PcSnHBEU/QHvFFTlX3MOMf8YBA= Received: by 10.37.2.70 with SMTP id e70mr2488697nzi; Sat, 04 Feb 2006 04:58:07 -0800 (PST) Received: by 10.36.74.5 with HTTP; Sat, 4 Feb 2006 04:58:07 -0800 (PST) Message-ID: Date: Sat, 4 Feb 2006 07:58:07 -0500 From: Jeff Trawick To: dev@apr.apache.org Subject: Re: svn commit: r374808 - in /apr/apr-util/branches/0.9.x: CHANGES build/apu-conf.m4 buildconf configure.in In-Reply-To: <20060204012057.64059.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060204012057.64059.qmail@minotaur.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 2/3/06, wrowe@apache.org wrote: > URL: http://svn.apache.org/viewcvs?rev=3D374808&view=3Drev > Log: > Fix VPATH builds, and symlink builds where apr and apr-util > reside in parallel as symlinks to directories with more explicit > names, e.g. apr-1.x and apr-util-1.x. This solves various breakage > on Solaris in particular with ./buildconf and ./configure. Also > eliminated the nested ../apr-iconv/buildconf, given that apr-util > didn't bother with ../apr/buildconf, and this was inconsistant. > Modified: apr/apr-util/branches/0.9.x/configure.in > URL: http://svn.apache.org/viewcvs/apr/apr-util/branches/0.9.x/configure.= in?rev=3D374808&r1=3D374807&r2=3D374808&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- apr/apr-util/branches/0.9.x/configure.in (original) > +++ apr/apr-util/branches/0.9.x/configure.in Fri Feb 3 17:20:52 2006 > @@ -186,8 +186,7 @@ > fi > > if test ! -d "$top_builddir/include/private"; then > - mkdir $top_builddir/include > - mkdir $top_builddir/include/private > + $mkdir_p $top_builddir/include/private Curious: righteous cleanup unrelated to rest of commit, or the include directory could sometimes exist when include/private didn't? Also, if we're moving to $mkdir_p, can't we just eliminate the test for pre-existence? (dunno if $mkdir_p is somehow hobbled w.r.t. normal "mkdir -p")