apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r374808 - in /apr/apr-util/branches/0.9.x: CHANGES build/apu-conf.m4 buildconf configure.in
Date Sat, 04 Feb 2006 12:58:07 GMT
On 2/3/06, wrowe@apache.org <wrowe@apache.org> wrote:

> URL: http://svn.apache.org/viewcvs?rev=374808&view=rev
> Log:
>   Fix VPATH builds, and symlink builds where apr and apr-util
>   reside in parallel as symlinks to directories with more explicit
>   names, e.g. apr-1.x and apr-util-1.x.  This solves various breakage
>   on Solaris in particular with ./buildconf and ./configure.  Also
>   eliminated the nested ../apr-iconv/buildconf, given that apr-util
>   didn't bother with ../apr/buildconf, and this was inconsistant.

> Modified: apr/apr-util/branches/0.9.x/configure.in
> URL: http://svn.apache.org/viewcvs/apr/apr-util/branches/0.9.x/configure.in?rev=374808&r1=374807&r2=374808&view=diff
> ==============================================================================
> --- apr/apr-util/branches/0.9.x/configure.in (original)
> +++ apr/apr-util/branches/0.9.x/configure.in Fri Feb  3 17:20:52 2006
> @@ -186,8 +186,7 @@
>  fi
>
>  if test ! -d "$top_builddir/include/private"; then
> -    mkdir $top_builddir/include
> -    mkdir $top_builddir/include/private
> +    $mkdir_p $top_builddir/include/private

Curious: righteous cleanup unrelated to rest of commit, or the include
directory could sometimes exist when include/private didn't?

Also, if we're moving to $mkdir_p, can't we just eliminate the test
for pre-existence?  (dunno if $mkdir_p is somehow hobbled w.r.t.
normal "mkdir -p")

Mime
View raw message