apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r374805 - in /apr/apr-util/trunk: CHANGES build/apu-conf.m4 buildconf
Date Sat, 04 Feb 2006 12:54:34 GMT
On 2/3/06, wrowe@apache.org <wrowe@apache.org> wrote:

> URL: http://svn.apache.org/viewcvs?rev=374805&view=rev
> Log:
>   Fix VPATH builds, and symlink builds where apr and apr-util
>   reside in parallel as symlinks to directories with more explicit
>   names, e.g. apr-1.x and apr-util-1.x.  This solves various breakage
>   on Solaris in particular with ./buildconf and ./configure.

> Modified: apr/apr-util/trunk/buildconf
> URL: http://svn.apache.org/viewcvs/apr/apr-util/trunk/buildconf?rev=374805&r1=374804&r2=374805&view=diff
> ==============================================================================
> --- apr/apr-util/trunk/buildconf (original)
> +++ apr/apr-util/trunk/buildconf Fri Feb  3 17:14:55 2006
> @@ -38,8 +38,7 @@
>    shift
>  done
>
> -if test -d "$apr_src_dir"
> -then
> +if [ -f "$apr_src_dir/build/apr_common.m4" ]; then

This type of construct isn't used in the generated configure (my lame
litmus test for whether it is portable).  Is it safe everywhere?

>    echo ""
>    echo "Looking for apr source in $apr_src_dir"
>  else
> @@ -84,17 +83,9 @@
>  $apr_src_dir/build/gen-build.py make
>
>  #
> -# If apr-iconv, then go and configure it.
> -#
> -if test -d ../apr-iconv; then
> -  echo "Invoking ../apr-iconv/buildconf.sh ..."
> -  (cd ../apr-iconv; ./buildconf)
> -fi
> -
> -#
>  # If Expat has been bundled, then go and configure the thing
>  #
> -if test -d xml/expat; then
> +if [ -f xml/expat/buildconf.sh ]; then

Curious: what does this change do?

Mime
View raw message