apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: [PATCH] Adjust more_finfo() on Win32 to behave more like its Unix/Linux counterpart
Date Fri, 10 Feb 2006 17:52:45 GMT
On 2/10/06, D.J. Heap <djheap@gmail.com> wrote:
> On 2/10/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> [snip]
> > Unfortunately no, this (along with the proposed backport of that other
> > revision, IIRC) has not yet been committed.  I haven't had a chance to
> > dig into it, and nobody with any win32-fu has looked at this AFAIK.
> >
> So if I understand correctly, 'incomplete' is a fatal error and
> Subversion (for example) should not attempt to deal with it and
> continue.  And this set of patches fixes apr to do that on Win32, but
> hasn't been verified to look and work correctly yet?

Well, it depends.  'incomplete' means you have to look at the 'valid'
member and see if the parts you care about are valid or not, IIRC. 
But yes, the reason this set of patches haven't been committed (in the
case of this patch) and merged back to the older branches (in the case
of the already committed rev in question) is that nobody has done the
leg work on it.  If you're willing to do the work of confirming that
the changes work correctly and makes sense (i.e. makes the code do
roughly the same thing on windows as it does on Unix) I'd be happy to
commit the changes.


View raw message