apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r376484 - /apr/apr/branches/1.2.x/test/testsock.c
Date Fri, 10 Feb 2006 08:20:42 GMT
On Thu, Feb 09, 2006 at 11:18:52PM -0000, William Rowe wrote:
> Author: wrowe
> Date: Thu Feb  9 15:18:50 2006
> New Revision: 376484
> 
> URL: http://svn.apache.org/viewcvs?rev=376484&view=rev
> Log:
> 
>   Avoid a hang if apr_accept() fails, permitting APR_EINPROGRESS
>   while we wait for apr_connect()
> 
> Backports; 376196, 376403
> Author; rooneg
...
> @@ -255,8 +257,8 @@
>      APR_ASSERT_SUCCESS(tc, "get remote address of client socket",
>                         apr_socket_addr_get(&ca, APR_REMOTE, cd));
>      
> -    apr_snprintf(a, sizeof a, "%pI", sa);
> -    apr_snprintf(b, sizeof b, "%pI", ca);
> +    a = apr_psprintf(p, "%pI", sa);
> +    b = apr_psprintf(p, "%pI", ca);

This was using snprintf because psprintf/%pI is broken in < 1.3.0, that 
needs to be reverted too.

joe

Mime
View raw message