apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r375919 - /apr/apr/trunk/test/testlfs.c
Date Wed, 08 Feb 2006 16:00:30 GMT
On Wed, Feb 08, 2006 at 03:48:05PM +0000, Joe Orton wrote:
> On Wed, Feb 08, 2006 at 07:43:07AM -0800, Garrett Rooney wrote:
> > On 2/8/06, jorton@apache.org <jorton@apache.org> wrote:
> > > Author: jorton
> > > Date: Wed Feb  8 02:48:25 2006
> > > New Revision: 375919
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=375919&view=rev
> > > Log:
> > > * test/testlfs.c (test_buffered): Add tests for seeking in buffered
> > > files.
> > 
> > Is this going to drop giant files on the filesystem of anyone who runs
> > it on something that doesn't support sparse files?  I know we had
> > trouble with that on Darwin fairly recently...
> 
> None of the tests in this file are run for for platforms which don't 
> define APR_HAS_LARGE_FILES - that includes BSD platforms with a 64-bit 
> native off_t, I presume Darwin counts as such.

Having said that, I guess this bug would have affected 32-bit BSD 
platforms in exactly the same way as LFS systems, so this test case 
*would* be useful outside testlfs.c, but lacking any way to detect 
sparse file support I'll just leave it as-is.

joe




Mime
View raw message