Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates
 64.233.184.198 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Y21Ong/XUYzFFGCVzIoowiKrSHU6jgXPQXrkAyXpIUuNZHwftKES/R3nOSyusqNyqN//VJgf2O3Mc/IIe0Ba76KtLaclsQqduxUgHXqmIhnqwjPSnA9OBRmhrN2T2cEx8zWvhjSd4PvIgejA9F+e3qmDmRVLoe/D8SG1pkxyOQY=
Message-ID: <7edfeeef0601271304y59250983jb24287c54695202a@mail.gmail.com>
Date: Fri, 27 Jan 2006 13:04:12 -0800
From: Garrett Rooney <rooneg@electricjellyfish.net>
Sender: rooneg@gmail.com
To: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: Status of patch?
Cc: dev@apr.apache.org
In-Reply-To: <43DA8775.7030008@rowe-clan.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <43DA8775.7030008@rowe-clan.net>

On 1/27/06, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
> This patch
>
> http://svn.apache.org/viewcvs.cgi/apr/apr/trunk/file_io/win32/readwrite.c=
?rev=3D314856&view=3Dmarkup
>
> backporting this patch
>
> http://svn.apache.org/viewcvs.cgi?view=3Drev&rev=3D76283
>
> to fix apr_vformatter on win32 is a little unclear to me; it's missing
> all the credits in the 'backport' and both were missing CHANGES?

Well, it's really more of a "sideport", since it's just going from the
unix code to the win32 code in the same version, and as for credits,
it did refer to the intial commit, which credited the contributors.

As for CHANGES entries, they could probably stand to have one, but the
committer of the initial change didn't add one and nobody complained
about it, so I didn't add one when I backported the changes to 1.2.x
and 0.9.x.

-garrett