Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates
 64.233.184.206 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=MRPlDfEkC39zHCLRxZM0Ewj4G8K+0zUqo3WcSuhK4lMEmldFlrddGvqf1VuURxFja9sQO3p2PC8nDRbROkR45TV5+eh4uG2p77lT8cBzdt8TPDaKwoFV7GY/WjORFvPMcP4CoQOxa/K5eB2GLcFUtCzBhUMhMHK9hLssUUJNZO8=
Message-ID: <7edfeeef0601212057g49c29f0co4a11d2a53a9bd2c0@mail.gmail.com>
Date: Sat, 21 Jan 2006 20:57:37 -0800
From: Garrett Rooney <rooneg@electricjellyfish.net>
Sender: rooneg@gmail.com
To: Norris Leong <mpleong@clustertech.com>
Subject: Re: [PATCH] win32 - dropped data in read_with_timeout
Cc: dev@apr.apache.org
In-Reply-To: <43D063E7.1050102@clustertech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <43D063E7.1050102@clustertech.com>

On 1/19/06, Norris Leong <mpleong@clustertech.com> wrote:
> Hi All,
>
> I suspect that read_with_timeout (in file_io/win32/readwrite.c) may drop
> data if
>
> (i) WaitForSingleObject (line 82) returns WAIT_TIMEOUT, and
> (ii) Data arrived before the execution arrives at CancelIo (line 105).
>
> Tried the attached patch and the problem seems solved.  I'm a novice of
> Windows' file mgmt API and would appreciate if somebody can validate
> this patch.

This seems reasonable to me, although I'm not anywhere close to a
win32 expert, so I can't say for sure.  Have you actually seen this
race in practice, or is it just a theoretical possibility?  I'm only
asking because I'd be much more comfortable applying a patch if the
contributor can say "this actually fixes a reproducable problem" ;-)

-garrett