Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 46556 invoked from network); 22 Jan 2006 10:44:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Jan 2006 10:44:08 -0000 Received: (qmail 19396 invoked by uid 500); 22 Jan 2006 10:44:07 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 19364 invoked by uid 500); 22 Jan 2006 10:44:06 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 19353 invoked by uid 99); 22 Jan 2006 10:44:06 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2006 02:44:06 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [207.155.248.54] (HELO revenge.cnchost.com) (207.155.248.54) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2006 02:44:06 -0800 Received: from [192.168.0.21] (c-24-13-128-132.hsd1.il.comcast.net [24.13.128.132]) by revenge.cnchost.com id FAA01254; Sun, 22 Jan 2006 05:43:38 -0500 (EST) [ConcentricHost SMTP Relay 1.17] Errors-To: Message-ID: <43D36163.3040709@rowe-clan.net> Date: Sun, 22 Jan 2006 04:41:39 -0600 From: "William A. Rowe, Jr." User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc3 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andreas Magnusson CC: dev@apr.apache.org Subject: Re: [PATCH] avoid crashing when given invalid user/group ids on win32 References: <7edfeeef0601211707me475cc2i485a301cc80d59a2@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Andreas Magnusson wrote: > But the entrypoint in the dll is the same as for LockServiceDatabase and > IsValidAcl (and many more), so they might not do anything on those old > versions. That would be consistent (in the case of IsValidAcl) with testing for the pattern not the meaning. Dunno why LockServiceDatabase would match to the same, perhaps you are right that it's an entirely bogus SUCCESS stub. But one assumes that if there is nothing to test, it probably wouldn't cause a crash, either. Bill