From dev-return-15401-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Jan 31 05:02:25 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 74189 invoked from network); 31 Jan 2006 05:02:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 Jan 2006 05:02:25 -0000 Received: (qmail 68607 invoked by uid 500); 31 Jan 2006 05:02:23 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 68558 invoked by uid 500); 31 Jan 2006 05:02:23 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 68546 invoked by uid 99); 31 Jan 2006 05:02:23 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2006 21:02:23 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates 64.233.184.196 as permitted sender) Received: from [64.233.184.196] (HELO wproxy.gmail.com) (64.233.184.196) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2006 21:02:22 -0800 Received: by wproxy.gmail.com with SMTP id i31so1178840wra for ; Mon, 30 Jan 2006 21:02:02 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=or/W1KV48nzWzHmWgyHFxRLuz46bPjnPiDY9mblX8guGgNJ41NEH+1dyneb0EL5MxacarTEH9hnoZ90RHos/3cXntD9ZtG17FDxvPUPp8F3L556Jw+aW3hFvhBI3jMzowBX4BJhWY7zRiiQf5Qnz9bkVA5vIxGhVZmVjnGB3umg= Received: by 10.54.112.10 with SMTP id k10mr3378201wrc; Mon, 30 Jan 2006 21:02:01 -0800 (PST) Received: by 10.54.120.17 with HTTP; Mon, 30 Jan 2006 21:02:01 -0800 (PST) Message-ID: <7edfeeef0601302102i41e917do3b0a4164fafe86b3@mail.gmail.com> Date: Mon, 30 Jan 2006 21:02:01 -0800 From: Garrett Rooney Sender: rooneg@gmail.com To: Brian Pane Subject: Re: [PATCH] testpoll fix Cc: dev@apr.apache.org In-Reply-To: <42EAF182-825B-4C89-BAD9-6F27DD493CF6@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <42EAF182-825B-4C89-BAD9-6F27DD493CF6@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 1/30/06, Brian Pane wrote: > This patch should allow the APR testpoll test to work with pollset > implementations > where readability and writability events on the same descriptor can > end up in two > separate pollfd_t objects, such as kqueue. > > The only pollset implementations for which I have test environments, > though, are > select and epoll. Can someone with *BSD please try this patch and > let me know if > testpoll passes with the kqueue impl? This passes the part that you modified, but it still fails further on... The apr_pollset_poll after the recv_msg results in a return value of 1, with rtnevents =3D APR_POLLIN | APR_POLLOUT. I guess kqueue is just more unpredictable in how it's going to return the data to you, which does seem to make things harder to test... -garrett