From dev-return-15241-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Jan 05 01:37:47 2006 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 16797 invoked from network); 5 Jan 2006 01:37:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Jan 2006 01:37:46 -0000 Received: (qmail 43266 invoked by uid 500); 5 Jan 2006 01:37:45 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 43213 invoked by uid 500); 5 Jan 2006 01:37:44 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 43202 invoked by uid 99); 5 Jan 2006 01:37:44 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2006 17:37:44 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [212.249.34.130] (HELO picanmix.dev.day.com) (212.249.34.130) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2006 17:37:43 -0800 Received: from eu-mail.day.com (eu-mail.dev.day.com [10.0.0.30]) by picanmix.dev.day.com (DAY) with ESMTP id k051bVF05861; Thu, 5 Jan 2006 02:37:31 +0100 (MET) Received: from [10.2.8.78] ([10.2.8.78]) by eu-mail.day.com (Lotus Domino Release 5.0.8) with ESMTP id 2006010502372962:9263 ; Thu, 5 Jan 2006 02:37:29 +0100 In-Reply-To: <20060105004235.k866zoe3z2g444og@lobstertechnology.com> References: <20060101150105.g571mpamfjeskcww@lobstertechnology.com> <200601011618.30009.nick@webthing.com> <20060102204354.d3922p1jtfwo0ck8@lobstertechnology.com> <20060105002903.wwuzqe7409wggow8@lobstertechnology.com> <7edfeeef0601041636n695c227dsf6f4b76870e76932@mail.gmail.com> <20060105004235.k866zoe3z2g444og@lobstertechnology.com> Mime-Version: 1.0 (Apple Message framework v746.2) Message-Id: <4C0D73A4-9846-4CFB-B4A8-015ECB9336BE@gbiv.com> Cc: dev@apr.apache.org From: "Roy T. Fielding" Subject: Re: UPDATE: [Patch] poll/unix/poll.c:apr_pollset_poll() optimisation Date: Wed, 4 Jan 2006 17:37:27 -0800 To: gerry@everythingsucks.co.uk X-Mailer: Apple Mail (2.746.2) X-MIMETrack: Itemize by SMTP Server on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 01/05/2006 02:37:29 AM, Serialize by Router on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 01/05/2006 02:37:30 AM, Serialize complete at 01/05/2006 02:37:30 AM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Jan 4, 2006, at 4:42 PM, gerry@everythingsucks.co.uk wrote: > Quoting Garrett Rooney : > >> Um, I don't think that's going to work, rv is the number of >> descriptors that hit, there's nothing that says that if N hit >> it'll be >> the first N... > > That would be true were I comparing I>> - for (i = 0; i < pollset->nelts; i++) { >>> + for (i = 0; j < rv; i++) { I have a vague recollection that there was some reason we couldn't trust the return value being equal to the number of ready descriptors on some platform, but I have no time to search the archives for why. I may be remembering something related to ... er .. that other call like poll... hmmm, oh, select. Or maybe I just need more caffeine. ....Roy