apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: [Fwd: DO NOT REPLY [Bug 38438] New: - apr_file_seek(file,APR_END,ofs) fails for APR_XTHREAD files]
Date Mon, 30 Jan 2006 06:43:00 GMT
On 1/29/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 1/29/06, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
> > I detest adding new patches at the end of the review cycle; this one however
> > looks correct, and is an edge case never triggered on httpd, but obviously
> > some folks are using the feature :-/
> >
> > Second set of eyeballs, please?
>
> At first glance it seems correct, although I don't know this code well.
>
> With that in mind, +0 to commit, +1 if you write a test for it ;-)
>
> I'll hold off on tagging new tarballs for a few hours, to give you a
> shot to get this in...

Actually, hold off, I've got a test, and it does seem to fix the
problem.  Will commit soon.

-garrett

Mime
View raw message