apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: [PATCH] win32 - dropped data in read_with_timeout
Date Mon, 30 Jan 2006 01:39:15 GMT
On 1/29/06, James Mansion <james@wgold.demon.co.uk> wrote:
> >race in practice, or is it just a theoretical possibility?  I'm only
> >asking because I'd be much more comfortable applying a patch if the
> >contributor can say "this actually fixes a reproducable problem" ;-)
>
> Are you suggesting that 'wrong by inspection' isn't reproducable?
>
> I know this sounds facetious, but race conditions are a pain to
> test for and really careful review of design and implementation
> is the answer IMO.

I'm saying that I don't know enough about win32 programming to
determine if something is "wrong" just by looking at it, so if I'm
actually going to commit this change I'd like to hear some indication
that it can actually happen.  Not to say that someone more comfortable
in this environment wouldn't just commit the change after seeing the
code, but I simply don't know enough to do that.

-garrett

Mime
View raw message