apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] apr_dso_open()
Date Fri, 06 Jan 2006 17:21:41 GMT
On Fri, Jan 06, 2006 at 08:04:53AM -0800, Jonathan wrote:
> Comments?
> 
> This adds apr_dso_open(). Its intention is to only open a dynamic shared 
> library and to do so without any further process to automatically bind 
> global symbols, unlike apr_dso_load().

Splitting the differrent implementations into separate files should be 
done separately to adding any new interfaces; if you wanted to submit a 
patch for that it's probably be a good idea.

For the new interface: offering GLOBAL|NOW and LAZY|LOCAL as the only 
two options is just odd; the most common uses I'd see would be 
GLOBAL|NOW and LOCAL|NOW, LAZY is useful only in rare cases.

I think any new function should just use flags to allow the user to 
choose any of the four combinations where possible. (I don't understand 
the vetoes on previous patches which did that, so I can't offer any 
advice on how to do this without still incurring a veto; try it and see 
I guess)

Regards,

joe

Mime
View raw message