From dev-return-15118-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Dec 07 22:06:50 2005 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 39258 invoked from network); 7 Dec 2005 22:06:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Dec 2005 22:06:50 -0000 Received: (qmail 36774 invoked by uid 500); 7 Dec 2005 22:06:48 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 36714 invoked by uid 500); 7 Dec 2005 22:06:47 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 36686 invoked by uid 99); 7 Dec 2005 22:06:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2005 14:06:47 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates 64.233.184.207 as permitted sender) Received: from [64.233.184.207] (HELO wproxy.gmail.com) (64.233.184.207) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2005 14:06:47 -0800 Received: by wproxy.gmail.com with SMTP id 68so805527wri for ; Wed, 07 Dec 2005 14:06:26 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jcFWBJIa1qgxWjiriftWFx3QCW4OOO0649Y7y4xcYk8jAKkdzLup9ixlOFQZ7GCaG0zo/OMwSpKMusNI5ODmJMSdzoa1BdjWzig/8x9UXbTvE9gNj/x8WaE1A1o5+aL8i5yRc+Y2yj1NX4LuaIXnTxxdILg3J0Kjqj2/G4Bi41w= Received: by 10.54.127.3 with SMTP id z3mr2476865wrc; Wed, 07 Dec 2005 14:06:26 -0800 (PST) Received: by 10.54.120.11 with HTTP; Wed, 7 Dec 2005 14:06:26 -0800 (PST) Message-ID: <7edfeeef0512071406m1e917031tffc184df1544338e@mail.gmail.com> Date: Wed, 7 Dec 2005 14:06:26 -0800 From: Garrett Rooney Sender: rooneg@gmail.com To: dev@apr.apache.org Subject: Re: svn commit: r354824 - in /apr/apr/trunk/random/unix: sha2.c sha2.h sha2_glue.c Cc: commits@apr.apache.org In-Reply-To: <43975B65.3030004@rowe-clan.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20051207182913.89871.qmail@minotaur.apache.org> <4397537B.4010805@rowe-clan.net> <5F9F85E6-CB89-4572-86CB-AF982CED0F6A@red-bean.com> <43975B65.3030004@rowe-clan.net> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 12/7/05, William A. Rowe, Jr. wrote: > I didn't see your comment to this, it seems these -should- be exported to= me. Don't we already have functions in the public API for calculating SHA1 hash= es? > >> It seems these should be public, and the '__'s will inevitably > >> confuse some > >> devs, as well as not following our conventions. > > > > Then we should document it as our convention. :-) > > Or something +1... _apr_foo or apr__foo is fine here. Actually, _apr_foo is not fine, leading underscores are in the C library's implementation namespace IIRC. -garrett