apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: svn commit: r354824 - in /apr/apr/trunk/random/unix: sha2.c sha2.h sha2_glue.c
Date Wed, 07 Dec 2005 22:06:26 GMT
On 12/7/05, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:

> I didn't see your comment to this, it seems these -should- be exported to me.

Don't we already have functions in the public API for calculating SHA1 hashes?

> >> It seems these should be public, and the '__'s will inevitably
> >> confuse some
> >> devs, as well as not following our conventions.
> >
> > Then we should document it as our convention. :-)
>
> Or something +1... _apr_foo or apr__foo is fine here.

Actually, _apr_foo is not fine, leading underscores are in the C
library's implementation namespace IIRC.

-garrett

Mime
View raw message